Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add arm64 support #12

Merged
merged 1 commit into from
Oct 31, 2023
Merged

feat: Add arm64 support #12

merged 1 commit into from
Oct 31, 2023

Conversation

ghislainbourgeois
Copy link
Contributor

Description

This PR enables building the AMF rock on arm64. This will currently not be done automatically by the CI however as we do not have access to arm runners. It currently enables manual testing on arm.

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ghislainbourgeois ghislainbourgeois requested a review from a team as a code owner October 31, 2023 13:07
@ghislainbourgeois ghislainbourgeois merged commit 5cb68f8 into main Oct 31, 2023
5 checks passed
@ghislainbourgeois ghislainbourgeois deleted the add-arm64-support branch October 31, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielArndt DanielArndt DanielArndt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghislainbourgeois @DanielArndt