Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move releases into publisher app #4902

Open
wants to merge 1 commit into
base: publisher-react-app
Choose a base branch
from

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Nov 7, 2024

Done

Moves the releases publisher section into the publisher react app. This PR converts the initReleases function into a React component, fetches the release data from an API endpoint rather than being passed to the template, and moves the releases section as it is into the publisher app.

The majority of this PR is moving files. Absolute minimal changes have been made as described above.

How to QA

Testing

  • This PR has tests
  • No testing required (explain why): Moving files mostly

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-15740

@webteam-app
Copy link

@steverydz steverydz changed the base branch from main to publisher-react-app November 7, 2024 13:11
@steverydz steverydz marked this pull request as ready for review November 7, 2024 13:16
@steverydz steverydz force-pushed the WD-14636-move-releases-into-publisher-app branch from 3287ef4 to 2049ebe Compare November 7, 2024 13:19
@steverydz steverydz force-pushed the WD-14636-move-releases-into-publisher-app branch from 2049ebe to b9ee281 Compare November 7, 2024 13:26
@ilayda-cp
Copy link
Contributor

one thing that i noticed is the default tracks are different for the lxd snap. For example in the production the default track is 5.21 but on the demo its latest. Also the "This is the default track for the snap. Clear default track" isnt visible for the default track in the demo.

In the demo the latest version is the default track:
Screenshot from 2024-11-08 11-01-11

When the 5.21 is selected its not shown as the default track in the demo:
Screenshot from 2024-11-08 11-00-57

In production 5.21 is the default track. Also the "Clear default track" button is available for the default track.
Screenshot from 2024-11-08 11-00-25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants