Refactor environment review out of test executions #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omar-selo
force-pushed
the
refactor-environment-review-out-of-test-executions
branch
from
c11266a
to
3e158d5
Compare
andrejvelichkovski
previously approved these changes
Oct 16, 2024
...d/migrations/versions/2024_10_02_1114-91e7e3f437a0_create_artefactbuildenvironmentreview_.py
Outdated
Show resolved
Hide resolved
andrejvelichkovski
approved these changes
Oct 16, 2024
andrejvelichkovski
deleted the
refactor-environment-review-out-of-test-executions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to support having and showing multiple runs or test executions per environment on artefacts we first need to take review concerns out of test executions. This PR does that.
Resolved issues
Resolves https://warthogs.atlassian.net/browse/RTW-365
Documentation
Web service API changes
review_decisionandreview_commenthave been removed from artefact builds endpointall_test_executions_countandcompleted_test_executions_counthave been replaced withall_environment_reviews_countandcompleted_environment_reviews_countin all endpoints that return an artefact for example https://test-observer-api.canonical.com/docs#/artefacts/get_artefacts_v1_artefacts_getTests
Added automated tests to backend and updated all tests as appropriate. Manually tested the frontend.