Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict channel users from editing billing details #14462

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

minkyngkm
Copy link
Contributor

@minkyngkm minkyngkm commented Nov 5, 2024

Done

  • Restrict distributor store users from editing billing details

QA

  • Check out this feature branch or go to the demo link
  • Go to /pro/distributor, /pro/subscribe and /credentials
  • Purchase an item for each shop
  • Distributor users should not be able to edit their tax and billing address info (Only card number)
  • Pro/credential users should be able to edit as before.

Issue / Card

Fixes #https://warthogs.atlassian.net/browse/WD-16449

Screenshots

before
image

after
image

before
image

after
image

@webteam-app
Copy link

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 84.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 69.76%. Comparing base (79b073b) to head (d7f5941).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
.../checkout/components/UserInfoForm/UserInfoForm.tsx 76.92% 6 Missing ⚠️
...tage/subscribe/checkout/components/Taxes/Taxes.tsx 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14462      +/-   ##
==========================================
+ Coverage   69.64%   69.76%   +0.12%     
==========================================
  Files         120      120              
  Lines        3419     3426       +7     
  Branches     1178     1177       -1     
==========================================
+ Hits         2381     2390       +9     
+ Misses       1013     1012       -1     
+ Partials       25       24       -1     
Files with missing lines Coverage Δ
...c/advantage/subscribe/checkout/utils/test/Mocks.ts 100.00% <100.00%> (ø)
...tage/subscribe/checkout/components/Taxes/Taxes.tsx 72.64% <91.30%> (+0.52%) ⬆️
.../checkout/components/UserInfoForm/UserInfoForm.tsx 66.66% <76.92%> (+2.75%) ⬆️

Copy link
Contributor

@fasih-mehmood fasih-mehmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants