Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollback saml plugin #130

Merged
merged 3 commits into from
Sep 19, 2023
Merged

rollback saml plugin #130

merged 3 commits into from
Sep 19, 2023

Conversation

gtrkiller
Copy link
Contributor

Applicable spec:

Overview

Delete the Miniorange SAML plugin

Rationale

Although SAML works just fine, the attribute mapping for teams cannot be used with an unpaid subscription

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

N/A

Checklist

@github-actions
Copy link
Contributor

Test coverage for 54be934

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/charm.py          521     41    164     28    89%   197-200, 338-339, 551, 582, 628, 663-664, 715-722, 727, 829, 834-835, 895, 913, 920, 1012, 1021, 1033, 1054, 1063, 1082, 1086, 1115, 1168, 1300, 1322, 1329->1331, 1370->exit, 1382, 1399-1401, 1419, 1428-1429
src/cos.py             15      0      0      0   100%
src/exceptions.py      17      1      2      1    89%   41
src/types_.py          15      0      0      0   100%
---------------------------------------------------------------
TOTAL                 568     42    166     29    90%

Static code analysis report

Run started:2023-09-19 14:39:31.917264

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4222
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@yanksyoon
Copy link
Collaborator

Hi @gtrkiller , :D I've had to merge this with #129, so that I could get the docs passing, would it be alright that this issue is closed? Sorry about that!

@gtrkiller gtrkiller merged commit cb041a3 into main Sep 19, 2023
25 checks passed
@gtrkiller gtrkiller deleted the rollback_saml branch September 19, 2023 17:13
@gtrkiller
Copy link
Contributor Author

@yanksyoon Sorry! just merged it, I didn't read the comment :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants