-
Notifications
You must be signed in to change notification settings - Fork 207
README: Add formatting and amend doc build instructions #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Additionally: - add formatting to Git branch names - add formatting to Python module names - consistently recommend 'python3 -m pip' iso. 'pip' - consistently use 'python3' iso. 'python' for command line examples - spell out Python version support
BTW; CI runs should be disabled for PRs like this. |
What's wrong with using Sorry, I have next to no experience with configuring GitHub actions. How would we exclude CI runs for certain changes? Is it worthwhile investigating that? |
I don't think |
André:
IIRC, because it's easy to end up using the "wrong" See also the Christian:
I don't use Windows, but yes, I believe you'll have to use André:
I also realised there is no docs build CI. I'll create an issue with some suggested CI improvements. Thanks both of you for reviewing. |
On windows, running
Footnotes
|
Well the Windows problem of Please go back to If the |
FYI: Setuptools docs and pip docs consequently use |
Sure, but IMO those are not conflicting goals. Well, I updated the PR according to your remarks. PTAL. |
@erlend-aasland Hm... Unfortunately this broke our PyPI uploads, as the Sphinx roles in README.rst are not acceptable for the parsing on PyPI. Will have to revert some of the formatting and try again with a v2.4.1 release. See https://github.com/canopen-python/canopen/actions/runs/16746953346/job/47407670531 |
Additionally:
consistently recommend 'python3 -m pip' iso. 'pip'consistently use 'python3' iso. 'python' for command line examples