Tests: make sure temporary files are pre-closed #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows fails with a permission error if the temporary file is already opened. Fixes canopen-python#501
erlend-aasland
force-pushed
the
ci/fix-windows
branch
from
14d44d0 to
fe6eb35
Compare
|
@sveinse, can you see if this mitigates the problems you experienced? |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #507 +/- ##
=======================================
Coverage 68.78% 68.78%
=======================================
Files 26 26
Lines 3117 3117
Branches 526 526
=======================================
Hits 2144 2144
Misses 835 835
Partials 138 138 |
acolomb
approved these changes
Jul 9, 2024
sveinse
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
@erlend-aasland I confirm that this PR fixes the issue on Windows. Approving.
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows fails with a permission error if the temporary file is already
opened.
Fixes #501