Skip to content

Fix debian package generation to include subdirectories #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

civerachb-cpr
Copy link

The existing .deb generation does not include subdirectories, resulting in missing modules:

image

  1. Move package information out of makedeb into setup.py as parameters
  2. Explicitly list all python modules that should be included in the package
  3. Replace the deb-generation command with python3 setup.py --command-packages=stdeb.command bdist_deb

Tested on Ubuntu 24.04; resulting debian file now includes the missing folders (see screenshot above)

@acolomb
Copy link
Member

acolomb commented Apr 27, 2025

Thanks for your contribution and for trying to improve the Debian package generation.

I don't think we want to proliferate stuff in setup.py. The package has already adopted a more modern approach based on the declarative pyproject.toml file. I have no experience with how Debian usually handles building Python packages, but I doubt that adding stuff to setup.py is state of the art. Of course, neither is an elaborate makedeb script including logic to extract the version string, so there is definitely room for improvment.

Building the package by itself should be left to the PyPA build helper: python3 -m build in the distro's top level directory. Or utilize the common Debian Python package build helpers, such as pybuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants