Use integer division in encode_phys to prevent rounding errors with int64 #611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing
int64
values with SDOs, I observed an unexpected behavior:Upon investigation, it appears that the issue originates from the
encode_phys
function:The problem lies in the fact that the division is performed using floating-point arithmetic rather than integer arithmetic, leading to rounding that causes a loss of up to 10 bits of precision.
To address this, we should detect whether the input value is an integer and, if so, perform integer division (
//
) instead of floating-point division. Additionally, it may be prudent to emit a warning whenfactor
is not an integer, as this could lead to precision loss.