Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add types for cds.build #266

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stockbal
Copy link
Contributor

@stockbal stockbal commented Oct 3, 2024

Adds types for cds.build to have proper type support when writing a custom CDS build plugin

@daogrady
Copy link
Contributor

daogrady commented Oct 8, 2024

Hi Ludwig,

thanks for this contribution! We're actually currently looking into how we can properly offer cds-dk types, hopefully without tainting the core cds types and causing too much confusion. I see that you have pointed out that the types are only available from dk in the comments, but I'd still like to put this on hold until we have figured some things out.

Best,
Daniel

@stockbal
Copy link
Contributor Author

stockbal commented Oct 8, 2024

Hi Daniel,

sure thing. It's not that high on my requirements list. I only created this PR because of the typescript issues in cds-plugin.js of cds-typer. I wanted to create another for cds.add as well, but put it hold because for cds.add the docs explicitly mention the use of @sap/cds-dk.

When you figured out how and where to add the dk-specific typings, just give a quick shout out, I am happy to do it 😊

Regards,
Ludwig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants