Add limitations about CAP Feature toggles to the documentation / readme #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sv7enNowitzki (random ping because I saw you merged last) any feedback on this? |
|
Hello Frank,
I will be modifying your PR before we merge it.
In essence, we have annotation flags to disable the automatic addition of the change view onto the model, as well as the facet, so the solution is actually even simpler than what you propose.
It will just take a couple of days because of my other, regular workload.
Best,
Nick
…________________________________
From: Frank Hufnagel ***@***.***>
Sent: Friday, September 27, 2024 9:32:09 AM
To: cap-js/change-tracking ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [cap-js/change-tracking] Add limitations about CAP Feature toggles to the documentation / readme (PR #120)
@Sv7enNowitzki<https://github.com/Sv7enNowitzki> (random ping because I saw you merged last) any feedback on this?
—
Reply to this email directly, view it on GitHub<#120 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD2JLF5QHIK6Q5TTCE55UFLZYUCXTAVCNFSM6AAAAABONIBBZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZYGYYDCNJSGA>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Thanks for the reply. Actually, I think my proposal is part of the solution that you describe. When disabling the UI facet creation + the creation of the association you have to create the association yourself (even though then you can name it "changes"). |
|
Exactly, then you can name it changes.
Best,
Nick
From: Frank Hufnagel ***@***.***>
Date: Friday, 27. September 2024 at 10:36
To: cap-js/change-tracking ***@***.***>
Cc: Josipovic, Nikica ***@***.***>, Comment ***@***.***>
Subject: Re: [cap-js/change-tracking] Add limitations about CAP Feature toggles to the documentation / readme (PR #120)
Thanks for the reply. Actually, I think my proposal is part of the solution that you describe. When disabling the UI facet creation + the creation of the association you have to create the association yourself (even though then you can name it "changes").
—
Reply to this email directly, view it on GitHub<#120 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD2JLFZPNKMOECEM5IJZCYDZYUKHJAVCNFSM6AAAAABONIBBZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZYG42TCMZVGI>.
You are receiving this because you commented.Message ID: ***@***.***>
|
nkaputnik
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue 116.
I think it's worth to add this to the readme, as it cost us quite some time to find this.