-
Notifications
You must be signed in to change notification settings - Fork 12
feat: Support change logs for bulk insert #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @nkaputnik @Sv7enNowitzki , I have created this PR to resolve the issue mentioned. This is my first time contributing to the repo. If I have missed anything, please let me know. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @akshay11298 ,
As I understand it, this plugin is designed following the standard behavior of Fiori elements. What I mean is that in standard Fiori element pages, processing is generally done from the perspective of updating a single root entity, which means that the situation you mentioned wasn't previously considered. This is indeed a shortcoming, so I made some changes based on your commit and expanded the unit tests to increase coverage. Thank you for your contribution.😄
Best Regards,
Wenjun
Hello @Sv7enNowitzki |
Hi @nkaputnik , |
Thanks @nkaputnik @Sv7enNowitzki for reviewing the PR and adding this feature 😄 |
Addresses- #145
Currently on bulk insert diff comes as an array instead of object, so extracting properties like ID (for entity key), or old_value (for change detection) returns undefined, since they need to be extracted from element of array. Updated the logic to iterate over diff if array, to treat each diff (row) individually, accumulating the changes and doing a bulk insert in ChangeLog entity.