Skip to content

chore: Upgrade to eslint9#172

Merged
danjoa merged 5 commits intomainfrom
eslint9
Apr 30, 2025
Merged

chore: Upgrade to eslint9#172
danjoa merged 5 commits intomainfrom
eslint9

Conversation

@danjoa
Copy link
Contributor

@danjoa danjoa commented Apr 24, 2025

How can we ensure this is merged soon?
Note: The tests fail with main as well.

@danjoa danjoa requested a review from sjvans April 29, 2025 05:56
@nkaputnik
Copy link
Contributor

@danjoa this was my concern. After seeing the failing tests, I needed to dig into the cause of the error (cds.autoexposed=false) and hesitated approving a PR with red crosses.
Do we know why the tests fail, or if there really is no cause for concern?

@Sv7enNowitzki
Copy link
Collaborator

Hello @danjoa ,

It seems that removing the change tracking dependency from devDependencies caused many attributes to stop working. I have added it back to the package.json, and everything is now functioning properly.

Best Regards,
Wenjun

@Sv7enNowitzki Sv7enNowitzki self-requested a review April 30, 2025 03:24
@danjoa
Copy link
Contributor Author

danjoa commented Apr 30, 2025

Perfect. Yes that was clearly the cause, as that dependency is required for the plugin to be detected and loaded. My mistake.
Thanks @Sv7enNowitzki 🙏

@danjoa danjoa merged commit f096b80 into main Apr 30, 2025
3 checks passed
@danjoa danjoa deleted the eslint9 branch April 30, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants