chore: Upgrade to eslint9 #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danjoa this was my concern. After seeing the failing tests, I needed to dig into the cause of the error (cds.autoexposed=false) and hesitated approving a PR with red crosses. |
|
Hello @danjoa , It seems that removing the change tracking dependency from devDependencies caused many attributes to stop working. I have added it back to the package.json, and everything is now functioning properly. Best Regards, |
Sv7enNowitzki
approved these changes
Apr 30, 2025
|
Perfect. Yes that was clearly the cause, as that dependency is required for the plugin to be detected and loaded. My mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How can we ensure this is merged soon?
Note: The tests fail with main as well.