Skip to content

chore: Prepare for cds9 #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

chore: Prepare for cds9 #179

merged 1 commit into from
May 8, 2025

Conversation

danjoa
Copy link
Contributor

@danjoa danjoa commented May 8, 2025

This is required for the tests in here to work with cds9.
It is not required for actual use of the plugin at runtime, or in production.

@nkaputnik nkaputnik merged commit 27ebef1 into main May 8, 2025
3 checks passed
@nkaputnik nkaputnik deleted the prep-for-cds9 branch May 8, 2025 10:34
Comment on lines +5 to +7
// Enable locale fallback to simulate end user requests
cds.env.features.locale_fallback = true

Copy link
Contributor

@johannes-vogel johannes-vogel May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatively, we could always set the default language header in tests.

const { axios, expect, data, POST, PATCH, DELETE } = cds.test(bookshop);
axios.defaults.headers.common['Accept-Language'] = 'en'

@nkaputnik
Copy link
Contributor

@johannes-vogel I already merged the PR, should we open a new one with your suggestion or are we good to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants