fix sample audit log #1276
Merged
fix sample audit log #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
what do you mean by that? https://github.com/cap-js/audit-logging?tab=readme-ov-file#annotate-personal-data is correct... |
|
the sample on the docs is missing |
got it, sorry. yes, should probably be there. |
sjvans
approved these changes
Sep 27, 2024
sjvans
reviewed
Sep 27, 2024
Co-authored-by: sjvans <[email protected]>
renejeglinsky
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
those additional lines are needed, otherwise no audit log event is written.
It seems that if those lines are missing, no audit log is written but also no error / warning is shown? -> Maybe that should be there in the plugin, too.