Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Telemetry support for Java #584

Merged
merged 12 commits into from
Dec 18, 2023
Merged

Open Telemetry support for Java #584

merged 12 commits into from
Dec 18, 2023

Conversation

StefanHenke
Copy link
Contributor

@StefanHenke StefanHenke commented Dec 12, 2023 •
edited
Loading

Includes:

  • Configuration on Cloud Foundry
  • custom instrumentation

Out:

  • Kyma support

BraunMatthias
BraunMatthias reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@BraunMatthias BraunMatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We should mention the logger and its effects
  • You could add a nice picture with the bar chart

Overall nice piece of docu!

java/observability.md Outdated Show resolved Hide resolved
java/observability.md Outdated Show resolved Hide resolved
java/observability.md Outdated Show resolved Hide resolved
java/observability.md Outdated Show resolved Hide resolved
java/observability.md Outdated Show resolved Hide resolved
java/observability.md Outdated Show resolved Hide resolved
java/observability.md Outdated Show resolved Hide resolved
java/observability.md Outdated Show resolved Hide resolved
java/observability.md Outdated Show resolved Hide resolved
@StefanHenke
Copy link
Contributor Author

  • We should mention the logger and its effects
  • You could add a nice picture with the bar chart

Overall nice piece of docu!

I have added both

BraunMatthias
BraunMatthias approved these changes Dec 15, 2023
View reviewed changes
java/observability.md Outdated Show resolved Hide resolved
java/observability.md Outdated Show resolved Hide resolved
java/observability.md Outdated Show resolved Hide resolved
@StefanHenke StefanHenke merged commit 0c5b8e4 into main Dec 18, 2023
3 of 4 checks passed
@StefanHenke StefanHenke deleted the otel branch December 18, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renejeglinsky renejeglinsky renejeglinsky approved these changes

@BraunMatthias BraunMatthias BraunMatthias approved these changes

@smahati smahati Awaiting requested review from smahati smahati is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StefanHenke @renejeglinsky @BraunMatthias