Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SAP Cloud Business Application Tools for Eclipse #606

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

mofterdinger
Copy link
Contributor

@mofterdinger mofterdinger commented Jan 2, 2024

The SAP Cloud Business Application Tools for Eclipse are no longer maintained and the last available version will be removed from the external Eclipse Update site: https://tools.hana.ondemand.com/

For René:

  • Remove also from Help Portal to avoid dead links

@mofterdinger
Copy link
Contributor Author

@renejeglinsky Hi Rene, I don't understand the build error. I couldn't find any reference to #eclipse in my PR branch. Do you have an idea ?
Thanks,
Markus

@@ -236,7 +236,7 @@ In addition you might want to remove the H2 dependency, which is included in the

If you don't want to exclude dependencies completely, but make sure that an in-memory H2 database **isn't** used, you can disable Spring Boot's `DataSource` auto-configuration, by annotating the `Application.java` class with `@SpringBootApplication(exclude = org.springframework.boot.autoconfigure.jdbc.DataSourceAutoConfiguration.class)`. In that mode CAP Java however can still react on explicit data source configurations or database bindings.

### What to Do About Maven-Related Errors in Eclipse's Problems View? { #eclipse}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mofterdinger maybe it's related to this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smahati Thanks, but I removed this reference in this PR as-well. Could it be related to references from the internal part of Capire ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm there are list of files where the references are supposed to be from, I'll check then individually and try to find them :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be remove by this PR: https://github.tools.sap/cap/docs/pull/510

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution here doesn't use any functionality the eclipse plugin provided?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it just uses features of the maven plugin in eclipse which is still installed.

@mofterdinger mofterdinger marked this pull request as ready for review January 8, 2024 09:07
@mofterdinger
Copy link
Contributor Author

Hi, can this PR be merged ?

@renejeglinsky renejeglinsky merged commit ed78d08 into main Jan 16, 2024
4 checks passed
@renejeglinsky renejeglinsky deleted the d032842_eclipse_cleanup branch January 16, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants