Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toggling for code fences #619

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Fix toggling for code fences #619

merged 3 commits into from
Jan 11, 2024

Conversation

swaldmann
Copy link
Contributor

@swaldmann swaldmann commented Jan 11, 2024

Currently code fences need an additional and explicit <div class="impl java"> wrapped around them to properly be hidden in { .impl .java } blocks, as the classes are not fully propagated. We only check for includes for java|node in the propagator, so the Vitepress-assigned language-java is also matched.

This can be seen for example on https://cap.cloud.sap/docs/guides/using-services#introduction: stay on the Node.js toggle and search for "DestinationConfiguration.java".

@swaldmann swaldmann marked this pull request as ready for review January 11, 2024 10:28
@swaldmann swaldmann requested a review from chgeo January 11, 2024 10:28
@chgeo chgeo merged commit a05fd01 into main Jan 11, 2024
3 checks passed
@chgeo chgeo deleted the fix-code-fences branch January 11, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants