Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(draft): Bypassing Draft Restrictions #639

Merged
merged 18 commits into from
Feb 1, 2024
Merged

feat(draft): Bypassing Draft Restrictions #639

merged 18 commits into from
Feb 1, 2024

Conversation

arleytm
Copy link
Contributor

@arleytm arleytm commented Jan 22, 2024

No description provided.

@arleytm arleytm self-assigned this Jan 24, 2024
node.js/fiori.md Outdated Show resolved Hide resolved
@arleytm arleytm changed the title feat(draft): SAP Fiori Elements Mass Edit feat(draft): Bypassing Draft Restrictions Jan 26, 2024
Copy link
Contributor

@johannes-vogel johannes-vogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add sample requests how to create/update entries.

node.js/fiori.md Outdated Show resolved Hide resolved
node.js/fiori.md Outdated Show resolved Hide resolved
node.js/fiori.md Outdated Show resolved Hide resolved
node.js/fiori.md Outdated Show resolved Hide resolved
node.js/fiori.md Outdated Show resolved Hide resolved
danjoa
danjoa previously requested changes Jan 29, 2024
Copy link
Contributor

@danjoa danjoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid feature flags as much as possible → can this be on by default?

@arleytm
Copy link
Contributor Author

arleytm commented Jan 30, 2024

@danjoa

We should avoid feature flags as much as possible → can this be on by default?

This would be a breaking change. You can refer to the warning section.
"bypass_draft": true could be the default when the new major version is released.

node.js/fiori.md Outdated Show resolved Hide resolved
@arleytm arleytm requested a review from danjoa January 31, 2024 13:11
@arleytm arleytm dismissed danjoa’s stale review February 1, 2024 13:48

#639 (comment) This feature was already shipped. So, I guess it is acceptable also to merge the documentation: #639 (comment) By the way, an annotation will also be provided for that purpose.

@arleytm arleytm merged commit 99bb7d4 into main Feb 1, 2024
4 checks passed
@arleytm arleytm deleted the bypass-draft branch February 1, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants