Update app_name attribute to use VCAP_APPLICATION.name#413
Draft
Update app_name attribute to use VCAP_APPLICATION.name#413
Conversation
PDT42
approved these changes
Mar 4, 2026
sjvans
commented
Mar 4, 2026
| LOG._info && LOG.info('Unable to require package.json to resolve app name and version due to error:', err) | ||
| } | ||
|
|
||
| const name = PKG?.name || VCAP_APPLICATION?.name || 'CAP Application' |
Contributor
There was a problem hiding this comment.
Suggested change
| const name = VCAP_APPLICATION?.name || PKG?.name || 'CAP Application' |
IMO: yes. I think we should only use deployment identifiers for OTel ids / names / keys. That is: I can't think of a scenario where a name attribute on root level should reference the package name rather than the deployment id 🤷♀️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.