Skip to content

feat!: update to Capacitor 7 #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 25, 2025
Merged

Conversation

gabekole
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [/ ] The changes have been tested successfully.

@tolutronics
Copy link
Contributor

Can someone approve this please

@bjornmassoels
Copy link

+1

@Zwarmex
Copy link

Zwarmex commented Mar 19, 2025

+1 too

@valentinbld45

This comment was marked as abuse.

@robingenz
Copy link
Member

Please fix the build and format your code so that we can merge this.

@Craic-T

This comment has been minimized.

@thammerl
Copy link
Contributor

thammerl commented Mar 24, 2025

@gabekole I created this pull request for your fork to fix the issues with the build and the code formatting.

thammerl and others added 3 commits March 24, 2025 21:10
 - `package-lock.json` is missing @rollup/rollup-darwin-arm64.
 - See npm/cli#4828.
Upgrade CI build to Java 21 and fix code formatting
@gabekole
Copy link
Contributor Author

gabekole commented Mar 24, 2025

Working on my repo now. @robingenz

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@capacitor-community/speech-recognition",
"version": "6.0.1",
"version": "7.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this. The version is bumped on release.

@robingenz
Copy link
Member

@gabekole Have you tested your changes?

@robingenz robingenz changed the title Update to capacitor 7 feat!: update to Capacitor 7 Mar 25, 2025
@gabekole gabekole requested a review from robingenz March 25, 2025 16:31
@robingenz robingenz merged commit bb13bee into capacitor-community:master Mar 25, 2025
2 checks passed
Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tolutronics
Copy link
Contributor

Thanks Guys!

@bjornmassoels
Copy link

yaaaaay! thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants