Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(analytics): setUserId accepts null values #757

Merged
merged 3 commits into from
Nov 19, 2024
Merged

fix(analytics): setUserId accepts null values #757

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c1580f
fix(analytics): setUserId accepts null values
simondaigre Nov 19, 2024
78b7317
Add changeset
simondaigre Nov 19, 2024
0f02048
Update .changeset/smooth-mirrors-bow.md
robingenz Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/smooth-mirrors-bow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@capacitor-firebase/analytics': minor
---

fix(analytics): setUserId accepts null values
robingenz marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion packages/analytics/src/web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export class FirebaseAnalyticsWeb

public async setUserId(options: SetUserIdOptions): Promise<void> {
const analytics = getAnalytics();
setUserId(analytics, options.userId || '');
setUserId(analytics, options.userId);
}

public async setUserProperty(options: SetUserPropertyOptions): Promise<void> {
Expand Down