Skip to content

Fix review script #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swaldmann merged 5 commits into from
Jan 19, 2024
Merged

Fix review script #636

swaldmann merged 5 commits into from
Jan 19, 2024

Conversation

@MatthiasAtSAP
Copy link
Contributor

@MatthiasAtSAP MatthiasAtSAP commented Jan 19, 2024

Fixes some issues:

  • We now filter the diffs we receive from the GitHub REST API by .md file type, since we only check these files anyway
  • the RegExp for extracting the context for empty links has become less restricted
  • if the context is too long, markdownlint-cli will truncate the string and append "..." at the end -> We have to remove these three dots

@MatthiasAtSAP MatthiasAtSAP enabled auto-merge (squash) January 19, 2024 15:24
@swaldmann swaldmann merged commit ef524b6 into main Jan 19, 2024
@swaldmann swaldmann deleted the fix-review branch January 19, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swaldmann swaldmann swaldmann approved these changes

@renejeglinsky renejeglinsky Awaiting requested review from renejeglinsky

@smahati smahati Awaiting requested review from smahati

@chgeo chgeo Awaiting requested review from chgeo chgeo is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MatthiasAtSAP @swaldmann