Feature/todo-adapter #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rossdanderson
commented
Nov 29, 2016
rossdanderson
commented
- Separate the Type2/Container/Row publishers
- Send containers via Transformer
Send container subscriptions via Transformer
* Add a "Todo List" adapter * Use locks for simplified code. Resend container contents to new peers. * naming improvements
codemedian
approved these changes
Feb 13, 2017
| @@ -93,7 +93,7 @@ add-data-service | |||
| end-data-service | |||
|
|
|||
| add-data-service | |||
| service-name ${ADAPTER_NAME}ContainerSvc${THIS_LEG} | |||
| service-name ${ADAPTER_NAME}TransformerContainerSvc${THIS_LEG} | |||
| include-pattern ^/TEMPLATE/CONTAINER | |||
There was a problem hiding this comment.
If we already send Containers and Type2 records via transformer we should probably do the same for pricing
added 2 commits
June 12, 2017 16:12
|
The templates have evolved quite significantly since this was raised. I've pulled out the pricing adapter changes and put them into develop but I've left the todo adapter in here. Can you bring this up to date with the pricing adapter (config wise) and I'll then merge it in? |
codemedian
force-pushed
the
feature/improvements
branch
from
c0d868c to
85cede7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.