chore: [#1541] Set time zone when running unit tests #1879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes 2 test failures that occur when running the unit tests on a device in any time zone other than GMT-2.
Contributor
Author
|
@capricorn86 I've updated this branch and all checks are now passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled down the repo to contribute a patch and noticed that two of the tests immediately failed on my device here in the US. I found #1541, which described the same issue and suggested this fix. Setting
TZwhen you have tests involving dates is, I think, fairly standard.✅ With this change, all tests pass on my machine.
Resolves #1026