fix: [#1880] Replace setTimeout with queueMicrotask where appropriate #1881
+17
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrevorBurnham
force-pushed
the
queue-microtask
branch
from
f331dde to
1e709d4
Compare
TrevorBurnham
changed the title
TrevorBurnham
force-pushed
the
queue-microtask
branch
from
8655554 to
f11dd91
Compare
…appropriate This commit replaces several instances of `setTimeout(..., 0)` with `queueMicrotask` to improve performance and align more closely with browser behavior for microtask scheduling. The main changes are: - In `MutationObserverListener`, mutation observer callbacks are now scheduled with `queueMicrotask`, as specified by the DOM standard. - In `Fetch`, the creation of a `ReadableStream` from a buffer now uses `queueMicrotask` to make the operation asynchronous more efficiently. - In `BrowserWindow`, `postMessage` now uses `queueMicrotask` to dispatch the `message` event. I've ignored the `setTimeout` in `@packages/happy-dom/src/window/BrowserWindow.ts` where it's being used to simulate smooth scrolling, since in that case the macrotask scheduling is necessary to accurately reflect DOM behavior.
TrevorBurnham
force-pushed
the
queue-microtask
branch
from
f11dd91 to
a9943a3
Compare
Contributor
Author
|
@capricorn86 I've updated this branch. All checks are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces several instances of
setTimeout(..., 0)withqueueMicrotaskto improve performance and align more closely with browser behavior for microtask scheduling.The main changes are:
MutationObserverListener, mutation observer callbacks are now scheduled withqueueMicrotask, as specified by the DOM standard.Fetch, the creation of aReadableStreamfrom a buffer now usesqueueMicrotaskto make the operation asynchronous more efficiently.BrowserWindow,postMessagenow usesqueueMicrotaskto dispatch themessageevent.I've ignored the
setTimeoutin@packages/happy-dom/src/window/BrowserWindow.tswhere it's being used to simulate smooth scrolling, since in that case the macrotask scheduling is necessary to accurately reflect DOM behavior.Resolves #1880