fix: Normalize DataTransfer format strings according to HTML spec #1965
+50
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the HTML spec, getData() should normalize format strings: - "text" should be treated as "text/plain" - "url" should be treated as "text/uri-list" - Format comparison should be case-insensitive This fixes issues with clipboard operations when testing libraries (like user-event) use shorthand format names. Reference: https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer-getdata
marchaos
force-pushed
the
fix/datatransfer-format-normalization
branch
from
199f1ff to
41155c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DataTransfer.getData()performs exact string matching on format types. However, according to the HTML spec, format strings should be normalized:"text"should be treated as"text/plain""url"should be treated as"text/uri-list"This causes issues when testing libraries (like
@testing-library/user-event) use shorthand format names. For example,user.paste('data')adds data with type"text", but application code callingevt.clipboardData.getData('text/plain')returns an empty string.Solution
Added format normalization in
getData()that:"text"→"text/plain""url"→"text/uri-list"Reference
https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer-getdata
Testing
Added tests for format normalization behavior.