Improve tests #179
Merged
Improve tests #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests generate a long operand list, which is hard to read under the default assertion error output. Use pretty_assertions to display the difference in a neat way.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the test suite by adding a new assertion library to improve test failure diffs.
- Introduce
pretty_assertionsas a development dependency for richer output in test failures.
Comments suppressed due to low confidence (1)
capstone-rs/Cargo.toml:25
- [nitpick] You’ve added
pretty_assertionsto improve test diffs but haven’t updated any tests to use it yet. Consider replacing standardassert_eq!calls in critical tests withpretty_assert_eq!so you can benefit from the enhanced output.
pretty_assertions = "1.4.1"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.