Add cargo features for arch support #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All archs enabled: 43MB. No archs enabled: 18MB. Only x86 arch enabled: 25MB.
There was a problem hiding this comment.
Pull Request Overview
This PR adds cargo feature flags for selective architecture support in Capstone, reducing binary size when non-essential architectures are disabled. Key changes include updating Cargo.toml files to include new arch-specific feature flags, modifying build.rs to conditionally define arch macros, and updating test configuration to gate tests based on specific arch features.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cstool/Cargo.toml | Updated capstone dependency to disable default features and added arch flags. |
| capstone-sys/build.rs | Introduced a macro to conditionally define architecture flags based on features. |
| capstone-sys/Cargo.toml | Added default inclusion of support_all_archs and arch-specific features. |
| capstone-rs/src/test.rs | Adjusted test configuration to require explicit arch flags for certain tests. |
| capstone-rs/src/arch/m68k.rs | Modified test configuration for m68k to also require the arch_m68k flag. |
| capstone-rs/Cargo.toml | Extended default features to include support_all_archs and mapped arch flags. |
| .github/workflows/main.yml | Added a workflow to run tests with only a limited set of arch features enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr implements the first and second approach for issue #61, which conditionally compiles capstone arch support based on cargo feature flags and enables arch modules on Rust side.
It reduces file size greatly:
cargo build:cstoolis 31MB in sizecargo build --no-default-features --features full,arch_x86:cstoolis 19MB in sizeIt disable Rust arch modules if feature flag is not provided. Creating capstone instance with disabled archs will fail with errors.