fix(ValueCard) Remove XSMALL from LEGACY_CARD_SIZES because we are using and displaying unwanted warnings

[anishkumar-bhut]

Summary
in ValueCard component have a CARD_SIZES and in that XSMALL is under LEGACY_CARD_SIZES but in Operation dashboard and other places XSMALL is using so in console unwanted warning displaying so added XSMALL in CARD_SIZES

Change List (commits, features, bugs, etc)

Acceptance Test (how to verify the PR)

• tests here

Regression Test (how to make sure this PR doesn't break old functionality)

• tests here

Things to look for during review

• Make sure all references to iot or bx class prefix is using the prefix variable
• (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
• UI should be checked in RTL mode to ensure the proper handling of layout and text.
• All strings should be translatable.
• The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
• Unit test should be written and should have a coverage of 90% or higher in all areas.
• All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
• Changes or new components should either write new or update existing documentation.
• PR should link and close out an existing issue

[netlify]

✅ Deploy Preview for carbon-addons-iot-react ready!

Name	Link
🔨 Latest commit	e00df1d
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-addons-iot-react/deploys/67dab5553898260008f59a9e
😎 Deploy Preview	https://deploy-preview-3935--carbon-addons-iot-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[herleraja]

is this supported ? As far as I'm aware support for XSMALL was removed. and when ever someone use XSMALL we used to change it to 'SMALL'

This may have impact on monitor dashboards.

[JordanWSmith15]

@herleraja Hello. Support for xsmall was removed, but we have a scenario in Maximo where the use of it is required again. It will only be allowed for certain simple Value cards, and there is likely some CSS cleanup and other work that will need to go in to that card type. What would work for Monitor here? Is there a condition or check we could add to isolate you from this change? @anishkumar-bhut @hectordavis @stuckless

[hectordavis]

Where exactly is the warning coming from? From what I can see here, ValueCard still uses the LEGACY_CARD_SIZES as expected sizes

[herleraja]

@JordanWSmith15 Just checked. I think the monitor should not be affected by this change.

We override the props accordingly.

Also, this may need to be well tested, because its used directly or indirectly
example if the size is small we won't display the error message icons. so we need to add the XSMALL size here too.

[herleraja]

@hectordavis the warning thrown in getUpdatedCardSize but that's thrown only in development mode. It should not effect in production.

[herleraja]

If its needed for value card may be you can do it specifically for value card. looks like getUpdatedCardSize function getting used in almost all the cards