Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio-button-group): set name attribute on inputs #1815

Closed
wants to merge 1 commit into from

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Sep 28, 2023

Fixes #1814, partially addresses #1813

Adds a name prop to RadioButtonGroup. If provided, name is set on the rendered input elements.

<RadioButtonGroup name="choices">
  <RadioButton id="1" value="1" />
  <RadioButton  id="2" value="2" />
</RadioButtonGroup>

<!-- DOM representation (abridged) -->
<fieldset>
  <input name="choices"  id="1" value="1" />
  <input name="choices"  id="2" value="2" />
</fieldset>

@brunnerh
Copy link
Contributor

Have you seen #1037?

@metonym
Copy link
Collaborator Author

metonym commented Sep 29, 2023

@brunnerh I haven't. Let's move to yours.

@metonym metonym closed this Oct 1, 2023
@metonym metonym deleted the fix-issue-1814 branch November 5, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RadioButtonGroup should forward name to underlying input elements
2 participants