HelperText as a generic component #1820
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is spread across several other components, and I had to use it on a custom project at some point, and I thought it would be a better option to be able to reuse the base Carbon feature directly as a Svelte component.
I ran
yarn build:docs
and it seems fine, and I updated all components using it so the behavior shouldn't change, since the HTML code behind is the same as before, so there is no breaking change.I also ran
yarn lint
, and it updated some other files, sorry for that 😅.I have questions though:
helperText
parameter should be flexible and injected either as an argument or as a<slot>
element, but IMO having both available is fine, please tell me if it's ok.Side-note: The initial reason for this was that at some point I noticed that some form components didn't have the
helperText
feature (like Checkbox for instance). So if this is merged, I think it's going to be a bit simpler to add support forhelperText
to many other components 👌