fix(code-snippet): showMoreLess={false}
should hide button
#1917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1536
Currently, the following does not work as intended:
The root cause is that
showMoreLess
is dynamically computed based on the code snippet height (the button is shown if a multi-line code snippet exceeds 255px). Additionally, theshowMoreLess
prop is initialized asfalse
when it should be the opposite (allowing the consumer to set it tofalse
).This PR fixes the logic:
boolean
valueshowMoreLess
is notfalse
Additionally, it adds the following examples to the docs: