Make library interoperable with Svelte 5 #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Eric Fulton <[email protected]>
Closes #1924 Svelte 5 will not compile if `div` is nested inside `p` element. Refactor Link to render an `a` instead of `p` when disabled.
In Svelte 5, the comment is ignored when it's above the input element. Setting the comment at the top-level resolves the issue.
theetrain
approved these changes
Mar 7, 2024
| @@ -79,6 +79,7 @@ | |||
| $: dispatch(expanded ? "expand" : "collapse"); | |||
| </script> | |||
|
|
|||
| <!-- svelte-ignore a11y-autofocus --> | |||
There was a problem hiding this comment.
Long-term, I recommend we remove autofocus functionality and guide users to instead utilize ref to manually set focus based on user or server events.
There was a problem hiding this comment.
Agreed – would love to sort out the ignorable a11y warnings from the rest.
|
Fix was released in v0.83.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review by commit – rebase merge.
#1908
There are several low-lift revisions that make this library interoperable with Svelte 5.
<p>#1924)