Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exports): resolve imports with explicit *.js extension #1927

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Mar 7, 2024

Fixes #1925

Importing using the explicit .*js extension will throw an error as these are not included in the package exports map. Normally, this would be acceptable if it's not part of the API.

However, the optimizeImports Carbon preprocessor rewrites certain imports (e.g., breakpoints) to the source *.js file.

Internal server error: Failed to resolve import "carbon-components-svelte/src/Breakpoint/breakpoints.js" from "src/App.svelte".

@metonym metonym merged commit 0405ede into master Mar 8, 2024
3 checks passed
@metonym metonym deleted the exports-map-explicit-js branch March 8, 2024 04:35
@metonym
Copy link
Collaborator Author

metonym commented Mar 8, 2024

Fixed in v0.84.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to resolve *.js imports
1 participant