ComboBox: add ability to type arbitrary values that weren't provided in items
#1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… aren't in `items`
McGaelen
changed the title
itemsitems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements #1726 by allowing users to type in any text they want into a
ComboBox, without having it removed. This functionality is behind a new flag, calledallowArbitraryValues. The default isfalse, which means that theComboBoxwill continue to function the same as it did before if the user does not enable it.When the value is not present in
items(it is an arbitrary value), the value ofselectedIdwill beundefined.Please let me know what changes are needed. If a separate component is desired instead, I'm happy to make the change.
Thanks!