-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Problem with cursor jumps and input behaviour for NumberInput #1945
Open
divinedesign-se
wants to merge
8
commits into
carbon-design-system:master
Choose a base branch
from
divinedesign-se:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5596120
fix: added pre-check for decimal deletion
divinedesign-se d7a2e80
docs: update guidance on `carbon-preprocess-svelte`
metonym 7d8a08b
docs: update guidance on `carbon-preprocess-svelte`
metonym 199c211
cleanup
divinedesign-se 4646364
revert location
divinedesign-se 6b0ed4c
cleaning
divinedesign-se 28baee9
getting previous value before changes are made
divinedesign-se 11b4842
cleanup
divinedesign-se File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire logic is hard to understand/follow, though I also don't know if/how it could be improved...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function starts by parsing the current value of the input field and storing it in previousValue. It then parses the new value of the input field and stores it in
possibleNewValue
and value.Next, it checks if the input action resulted in a transition from a non-integer to an integer. This is determined by the
isIntegerTransition
variable, which is true if data is undefined,previousValue
is not an integer, andpossibleNewValue
is an integer.If
isIntegerTransition
is true and the new value is less than the previous value, it sets the cursor position to the end of the input field after the next tick.If
isIntegerTransition
is true, the new value is greater than the previous value, and the previous value is not undefined, it splits the previous value into integer and fractional parts. Depending on the inputType, it removes a character from the fractional part or the integer part. It then joins the parts back together, parses the result, and sets it as the new value. It also sets the cursor position to a specific position after the next tick.If
isIntegerTransition
is false, the new value is equal to the previous value, and theinputType
is "deleteContentForward" (meaning the user pressed delete key instead of backspace), it sets the value to 0 and the cursor position to the start of the input field after the next tick.If none of the above conditions are met, it simply sets the value to
possibleNewValue
.