Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(breadcrumb)!: integrate Breadcrumb with v11 #1956

Merged
merged 1 commit into from
Apr 21, 2024
Merged

feat(breadcrumb)!: integrate Breadcrumb with v11 #1956

merged 1 commit into from
Apr 21, 2024

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Apr 21, 2024

Breaking Changes

  • Breadcrumb skeleton prop removed. Use BreadcrumbSkeleton directly.
  • Breadcrumb forwarded events removed from nav (a11y warning resolved)
  • BreadcrumbSkeleton forwarded events removed (a11y warning resolved)

Fixes

- BreadcrumbItem: correctly type aria-attributes

  • BreadcrumbItem forwarded events should be forwarded to Link, not li
  • BreadcrumbItem aria-current should be unset on li since it is passed to Link

Docs

  • Add example for a custom slot
  • Document more skeleton states

@metonym metonym merged commit 1600308 into next/v11-styles Apr 21, 2024
1 check passed
@metonym metonym deleted the next/v11-breadcrumbs branch April 21, 2024 19:14
@n-peugnet n-peugnet mentioned this pull request Aug 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@metonym