Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(breakpoint): integrate Breakpoint with v11 #1957

Merged
merged 1 commit into from
Apr 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion COMPONENT_INDEX.md
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ export type BreakpointValue = 320 | 672 | 1056 | 1312 | 1584;

| Prop name | Required | Kind | Reactive | Type | Default value | Description |
| :-------- | :------- | :--------------- | :------- | -------------------------------------------- | ------------------------------------------------------------------------- | ------------------------------------------------- |
| sizes | No | <code>let</code> | Yes | <code>Record<BreakpointSize, boolean></code> | <code>{ sm: false, md: false, lg: false, xlg: false, max: false, }</code> | Carbon grid sizes as an object |
| sizes | No | <code>let</code> | Yes | <code>Record<BreakpointSize, boolean></code> | <code>{ sm: false, md: false, lg: false, xlg: false, max: false, }</code> | Bind to all Carbon grid breakpoints. |
| size | No | <code>let</code> | Yes | <code>BreakpointSize</code> | <code>undefined</code> | Determine the current Carbon grid breakpoint size |

### Slots
Expand Down
2 changes: 1 addition & 1 deletion docs/src/COMPONENT_API.json
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@
{
"name": "sizes",
"kind": "let",
"description": "Carbon grid sizes as an object",
"description": "Bind to all Carbon grid breakpoints.",
"type": "Record<BreakpointSize, boolean>",
"value": "{ sm: false, md: false, lg: false, xlg: false, max: false, }",
"isFunction": false,
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/Breakpoint.svx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import Preview from "../../components/Preview.svelte";
</script>

The [Carbon Design System grid implementation](https://carbondesignsystem.com/guidelines/2x-grid/implementation#responsive-options) defines five responsive breakpoints:
The [Carbon Design System grid implementation](https://carbondesignsystem.com/elements/2x-grid/overview/#breakpoints) defines five responsive breakpoints:

<UnorderedList svx-ignore style="margin-bottom: var(--bx-spacing-08)">
<ListItem><strong>Small</strong>: less than 672px</ListItem>
Expand Down
8 changes: 6 additions & 2 deletions src/Breakpoint/Breakpoint.svelte
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<script>
// @ts-check

/**
* @typedef {"sm" | "md" | "lg" | "xlg" | "max"} BreakpointSize
* @typedef {320 | 672 | 1056 | 1312 | 1584} BreakpointValue
Expand All @@ -13,7 +15,7 @@
export let size = undefined;

/**
* Carbon grid sizes as an object
* Bind to all Carbon grid breakpoints.
* @type {Record<BreakpointSize, boolean>}
*/
export let sizes = {
Expand All @@ -28,6 +30,7 @@
import { breakpointObserver } from "./breakpointObserver";
import { breakpoints } from "./breakpoints";

/** @type {import("svelte").EventDispatcher<{ change: { size: BreakpointSize; breakpointValue: BreakpointValue; } }>} */
const dispatch = createEventDispatcher();
const observer = breakpointObserver();

Expand All @@ -39,8 +42,9 @@
xlg: size == "xlg",
max: size == "max",
};
$: if (size != undefined)
$: if (size != undefined) {
dispatch("change", { size, breakpointValue: breakpoints[size] });
}
</script>

<slot size="{size}" sizes="{sizes}" />
3 changes: 2 additions & 1 deletion src/Breakpoint/breakpointObserver.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,9 @@ export function breakpointObserver() {
}

function checkSizeValid(size) {
if (size in breakpoints == false)
if (size in breakpoints == false) {
throw new Error(`"${size}" is not a valid breakpoint size.`);
}
}

export default breakpointObserver;
3 changes: 2 additions & 1 deletion src/Breakpoint/breakpoints.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/**
* Pixel sizes of Carbon grid breakpoints.
* Carbon grid breakpoints in px.
* @see https://carbondesignsystem.com/elements/2x-grid/overview/#breakpoints
* @type {Record<import("./breakpoints").BreakpointSize, BreakpointValue>}
*/
export const breakpoints = Object.freeze({
Expand Down
2 changes: 1 addition & 1 deletion types/Breakpoint/Breakpoint.svelte.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export interface BreakpointProps {
size?: BreakpointSize;

/**
* Carbon grid sizes as an object
* Bind to all Carbon grid breakpoints.
* @default { sm: false, md: false, lg: false, xlg: false, max: false, }
*/
sizes?: Record<BreakpointSize, boolean>;
Expand Down
Loading