fix(data-table): prefix internal ID for radio button, checkbox #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theetrain
reviewed
Jan 8, 2025
Comment on lines
505
to
509
| <RadioButton | ||
| name="select-row-{row.id}" | ||
| name="{id}-{row.id}" | ||
| checked={selectedRowIds.includes(row.id)} | ||
| on:change={() => { | ||
| selectedRowIds = [row.id]; |
There was a problem hiding this comment.
If we can, I suggest taking this opportunity to provide a solution that affords progressive enhancement:
- Have the
nameattribute be defined by the component consumers; perhaps exposed as a prop, that way every Radio button in the table has a matchingnameto be gathered server-side viaformData.get('school') - Have the
valueattribute match the given Row's ID, available inrow.id
In this way, a DataTable can be wrapped in <form> and be submittable without JS.
There was a problem hiding this comment.
Good call. You're right – the name should in fact be the same for all rows in the table (barring the select all).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2081
Create an internal ID prefix for the radio buttons and checkboxes used within
DataTable.This addresses the case where multiple
DataTableinstances may be instantiated, and the data contains overlapping IDs inrows.