Skip to content

fix(list-box): set aria-disabled if disabled (#2125) #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2025

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Mar 23, 2025

This re-applies #2125, which was reverted in #2130

Carbon styles depend on the [disabled] attribute. The disabled attribute is not valid mark-up when applied to div role="option", so this PR preserved the existing disabled attribute while also setting aria-disabled.

@metonym metonym force-pushed the reapply-aria-disabled-list-box branch from b79c7f9 to 96d45e9 Compare March 23, 2025 17:43
@metonym metonym merged commit 9b61af0 into master Mar 23, 2025
3 checks passed
@metonym metonym deleted the reapply-aria-disabled-list-box branch March 23, 2025 17:46
@metonym
Copy link
Collaborator Author

metonym commented Mar 24, 2025

Fixed in v0.88.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant