feat: improve typing for DataTable row and cell #816
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #667 (maybe)
Thank you for such a nice library 🎉
When using DataTable component, it would be great if the editor autocompletes
headers
prop or slot values(cell.key
orrow
).I make it possible with Generics(named
Row
). For example,extends DataTableRow
restrict Row type (e.g. it should haveid
property).= DataTableRow
is to avoid breaking change.Feel free to:
without say anything.
demo (autocomplete is working correctly by this PR)
data-table-typing.mp4
code in demo