feat(chat): extensive updates to code charts and chat #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocornec
requested review from
alisonjoseph,
emyarod,
matthewgallo and
anamikaanu96
and removed request for
a team
❌ Deploy Preview for carbon-labs-web-components failed. Why did it fail? →
|
✅ Deploy Preview for carbon-labs-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
elycheea
reviewed
May 1, 2025
There was a problem hiding this comment.
I didn’t catch too many issues but there are a few small ones that we should update in this PR:
- Remove conflict markers
- Look into the broken charts on the Faceting test story
Things that can be addressed later:
- Clean up unused code/comments
- Fix the table in Code docs
Comment on lines
+454
to
+462
| <<<<<<< HEAD | ||
| <h4>Multi-scatter-chart</h4> | ||
| <clabs-chat-chart | ||
| content="${'{"$schema":"https://vega.github.io/schema/vega-lite/v5.json","repeat":{"row":["Horsepower","Acceleration","Miles_per_Gallon"],"column":["Miles_per_Gallon","Acceleration","Horsepower"]},"spec":{"data":{"url":"https://vega.github.io/vega-lite/examples/data/cars.json"},"mark":"point","params":[{"name":"brush","select":{"type":"interval","resolve":"union","on":"[pointerdown[event.shiftKey], window:pointerup] > window:pointermove!","translate":"[pointerdown[event.shiftKey], window:pointerup] > window:pointermove!","zoom":"wheel![event.shiftKey]"}},{"name":"grid","select":{"type":"interval","resolve":"global","translate":"[pointerdown[!event.shiftKey], window:pointerup] > window:pointermove!","zoom":"wheel![!event.shiftKey]"},"bind":"scales"}],"encoding":{"x":{"field":{"repeat":"column"},"type":"quantitative"},"y":{"field":{"repeat":"row"},"type":"quantitative","axis":{"minExtent":30}},"color":{"condition":{"param":"brush","field":"Origin","type":"nominal"},"value":"grey"}}}}'}" | ||
| container-height="450px" | ||
| container-width="600px"> | ||
| </clabs-chat-chart> | ||
| <br /> | ||
| ======= >>>>>>> upstream/main |
There was a problem hiding this comment.
Another conflict marker over here. Was this section meant to be removed? Can you double check?
Also noticing that weather example and concat aren’t loading in the Faceting test story.
| @@ -78,6 +78,78 @@ | |||
| } | |||
| } | |||
| }, | |||
| { | |||
| "title": "", | |||
| "prompt": "Make a pair-plot of all columns with scatter plots, use bar distributions when coloumns match", | |||
There was a problem hiding this comment.
Suggested change
| "prompt": "Make a pair-plot of all columns with scatter plots, use bar distributions when coloumns match", | |
| "prompt": "Make a pair-plot of all columns with scatter plots, use bar distributions when columns match", |
There was a problem hiding this comment.
Can probably clean up some of the comments if no longer in use.
| <td>`debug-editing-mode`</td> | ||
| <td>`boolean`</td> | ||
| <td>Show overlapping text in virtual text-area</td> | ||
| <td>To debug issues with editing mode resizing etc</td> | ||
| </tr> | ||
| <tr> | ||
| <td>`customLabels`</td> |
There was a problem hiding this comment.
Pretty minor but noticed this is missing a last cell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
{{short description}}
Changelog
New
Changed
Removed
Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}