-
Notifications
You must be signed in to change notification settings - Fork 33
feat(chat): extensive updates to code charts and chat #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ocornec
wants to merge
17
commits into
carbon-design-system:main
Choose a base branch
from
ocornec:owen-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
75a3819
chore(chat): new feedback, chart analysis
ocornec 599e57d
chore(chat): chart spec handling, code examples
ocornec 7c73e42
chore(chat): removed missing import
ocornec a084646
chore(chat): complete chart ingestion, mutli-option code
ocornec 739d4f7
chore(chat): chart fixes, new code examples, code resize fixes
ocornec a48ecf9
chore(chat): merge fixes
ocornec 09c29ed
chore(chat): extensive code updates, formula rendering, chart edits
ocornec 61c889a
chore(chat): merge
ocornec cc51926
chore(chat): added yarn lock
ocornec 9e2e481
Merge remote-tracking branch 'upstream/main' into code-updates-formul…
ocornec 8f5e78c
chore(chat): code fixes, demos
ocornec fb08f42
chore(chat): code, charts updates
ocornec 2b9324c
chore(chat): merged and updated charts and code
ocornec 16c708a
Merge remote-tracking branch 'upstream/main' into code-updates-formul…
ocornec 387a8bc
Updated examples3.json
ocornec 41b061b
Update CODEOWNERS conflict
ocornec 44691df
Undid welcome.scss include change
ocornec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -78,6 +78,78 @@ | |||||
} | ||||||
} | ||||||
}, | ||||||
{ | ||||||
"title": "", | ||||||
"prompt": "Make a pair-plot of all columns with scatter plots, use bar distributions when coloumns match", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
"result": { | ||||||
"$schema": "https://vega.github.io/schema/vega-lite/v5.json", | ||||||
"data": { | ||||||
"url": "https://vega.github.io/editor/data/weather.csv" | ||||||
}, | ||||||
"repeat": { | ||||||
"row": [ | ||||||
"Row1", | ||||||
"Row2" | ||||||
], | ||||||
"column": [ | ||||||
"Col1", | ||||||
"Col2", | ||||||
"Col3" | ||||||
] | ||||||
}, | ||||||
"spec": { | ||||||
"vconcat": [ | ||||||
{"title":"layered Chart", | ||||||
"layer": [ | ||||||
{ | ||||||
"mark": "line", | ||||||
"encoding": { | ||||||
"x": { | ||||||
"field": "date", | ||||||
"type": "temporal" | ||||||
}, | ||||||
"y": { | ||||||
"field": "temp_max", | ||||||
"type": "quantitative" | ||||||
}, | ||||||
"color":{"field": "weather", "type":"nominal"} | ||||||
} | ||||||
}, | ||||||
{ | ||||||
"mark": "point", | ||||||
"encoding": { | ||||||
"x": { | ||||||
"field": "date", | ||||||
"type": "temporal" | ||||||
}, | ||||||
"y": { | ||||||
"field": "temp_min", | ||||||
"type": "quantitative" | ||||||
}, | ||||||
"color":{"field": "weather", "type":"nominal"} | ||||||
} | ||||||
} | ||||||
] | ||||||
}, | ||||||
{ | ||||||
"title":"lower chart", | ||||||
"height":50, | ||||||
"mark":"bar", | ||||||
"encoding": { | ||||||
"x": { | ||||||
"field": "date", | ||||||
"type": "temporal" | ||||||
}, | ||||||
"y": { | ||||||
"field": "precipitation", | ||||||
"type": "quantitative" | ||||||
}, | ||||||
"color":{"field": "weather", "type":"nominal"} | ||||||
} | ||||||
} | ||||||
]} | ||||||
} | ||||||
}, | ||||||
{ | ||||||
"title": "", | ||||||
"prompt": "Create two violin plots with sepal width", | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another conflict marker over here. Was this section meant to be removed? Can you double check?
Also noticing that weather example and concat aren’t loading in the Faceting test story.