-
Notifications
You must be signed in to change notification settings - Fork 48
chore: add toolbar example as a pattern (story only) #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add toolbar example as a pattern (story only) #560
Conversation
✅ Deploy Preview for carbon-labs-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-labs-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
packages/web-components/src/patterns/toolbar/__stories__/toolbar.mdx
Outdated
Show resolved
Hide resolved
…ar.mdx Co-authored-by: elysia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s remove the package-lock since we don’t need to include these in examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elycheea, i had to refactor a lot of this structure, to be consistent with how we are delivering patterns. taking reference from ibm products.
also adds a complete lit example instead html, being consistent with ibm-products
i also had to add a lit plugin for vite config to load lit example styles in storybook.
pls have a second look when you get some time. 😄
jlongshore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really clean work, LGTM
a004d96
Closes carbon-design-system/ibm-products#7111
adds an example code to show how we can build toolbar out of carbon components
adds stackblitz examples
Changelog
New