Skip to content

Conversation

@devadula-nandan
Copy link
Contributor

@devadula-nandan devadula-nandan commented Apr 8, 2025

Closes carbon-design-system/ibm-products#7111

adds an example code to show how we can build toolbar out of carbon components
adds stackblitz examples

Changelog

New

  • added story for toolbar (story only, there is no component)
  • added stackblitz example

@netlify
Copy link

netlify bot commented Apr 8, 2025

Deploy Preview for carbon-labs-web-components ready!

Name Link
🔨 Latest commit a268807
🔍 Latest deploy log https://app.netlify.com/projects/carbon-labs-web-components/deploys/682745b64426cc0008ce8def
😎 Deploy Preview https://deploy-preview-560--carbon-labs-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Apr 8, 2025

Deploy Preview for carbon-labs-react ready!

Name Link
🔨 Latest commit a268807
🔍 Latest deploy log https://app.netlify.com/projects/carbon-labs-react/deploys/682745b6a05686000863aaa1
😎 Deploy Preview https://deploy-preview-560--carbon-labs-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@devadula-nandan devadula-nandan marked this pull request as ready for review April 24, 2025 10:28
@devadula-nandan devadula-nandan requested a review from a team as a code owner April 24, 2025 10:28
@devadula-nandan devadula-nandan requested review from davidmenendez and sangeethababu9223 and removed request for a team April 24, 2025 10:28
@devadula-nandan devadula-nandan requested a review from elycheea May 6, 2025 11:50
@matthewgallo matthewgallo self-requested a review May 7, 2025 14:25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s remove the package-lock since we don’t need to include these in examples.

Copy link
Contributor Author

@devadula-nandan devadula-nandan May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elycheea, i had to refactor a lot of this structure, to be consistent with how we are delivering patterns. taking reference from ibm products.
also adds a complete lit example instead html, being consistent with ibm-products
i also had to add a lit plugin for vite config to load lit example styles in storybook.

pls have a second look when you get some time. 😄

@devadula-nandan devadula-nandan requested a review from elycheea May 16, 2025 14:08
Copy link
Contributor

@jlongshore jlongshore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really clean work, LGTM

@elycheea elycheea added this pull request to the merge queue Jun 4, 2025
Merged via the queue into carbon-design-system:main with commit a004d96 Jun 4, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toolbar as a pattern in Labs

3 participants