You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During sizing/refinement pt 2 today, we were leaning towards the name Resizer instead of ResizeBar since that feels a bit more generic and allows for more flexibility if there are future iterations on it.
In general the component works well and represents the intent of the design.
There is a stolen focus issue that means the drag line can jump or be moved without the mouse being depressed.
Right click on the drag line to show the context menu on the single panel no boundaries story and select 'inspect' and note the line jumps. It may be possible to view this in other scenarios.
With another application open, right click on the line to show the context menu and then use Cmd+Tab to switch to the other application. When you click back to the browser the line is draggable even though the mouse button has been released.
The implementation uses non-context layer tokens such as layer-01 and border-subtle-01. In general we should avoid using non-contextual values (those with numbers) in favour of the layer context sensitive versions e.g. layer and border-subtle.
NOTE: Personally I find the visuals lack a clear drag handle and the thickened line does unintuitive. This is especially true if the drag line meets a screen edge (see image). I have mocked up a small drag handle below. This could be used on both sides with multiple panels.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devadula-nandan
changed the title
contributes resizer to carbon labs
Changelog
New
Testing / Reviewing
deploy preview
automated tests added