-
Notifications
You must be signed in to change notification settings - Fork 7
Headers -> Tabbed headers + Global filters #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Headers -> Tabbed headers + Global filters #64
Conversation
amal-k-joy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the compilation errors.
@carbon/ibm-products, @tanstack/match-sorter-utils are missing in package.json of both react and webcomponents
fixed |
elycheea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we’re missing @carbon/ibm-products as a dependency for the NoDataEmptyState in the React version?
Don’t forget we can remove the yarn.lock as well. 😄
added dependency there seems to be some issue with react not rendering in stackblitz, looking into it |
davidmenendez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elycheea fixed it. issue comes from c4ip peer dependency on react version, which made tabs to not render anything. removed |
closes #49
closes #50
Changes Headers to Tabbed headers in all instances React & WC
Implements Global filters into Tabbed headers React & WC
preview React: https://stackblitz.com/github/devadula-nandan/tanstack-carbon/tree/feat/tabbed-headers-search/react/tabbed-header
preview WC: https://stackblitz.com/github/devadula-nandan/tanstack-carbon/tree/feat/tabbed-headers-search/web-components/tabbed-header