Skip to content

Conversation

@devadula-nandan
Copy link
Contributor

@devadula-nandan devadula-nandan commented Jun 9, 2025

closes #49
closes #50

Changes Headers to Tabbed headers in all instances React & WC
Implements Global filters into Tabbed headers React & WC

preview React: https://stackblitz.com/github/devadula-nandan/tanstack-carbon/tree/feat/tabbed-headers-search/react/tabbed-header

preview WC: https://stackblitz.com/github/devadula-nandan/tanstack-carbon/tree/feat/tabbed-headers-search/web-components/tabbed-header

Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the compilation errors.
@carbon/ibm-products, @tanstack/match-sorter-utils are missing in package.json of both react and webcomponents

@devadula-nandan
Copy link
Contributor Author

Fix the compilation errors. @carbon/ibm-products, @tanstack/match-sorter-utils are missing in package.json of both react and webcomponents

fixed

Copy link
Contributor

@elycheea elycheea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we’re missing @carbon/ibm-products as a dependency for the NoDataEmptyState in the React version?

https://stackblitz.com/github/devadula-nandan/tanstack-carbon/tree/feat/tabbed-headers-search/react/tabbed-header?file=package.json

Don’t forget we can remove the yarn.lock as well. 😄

@devadula-nandan
Copy link
Contributor Author

devadula-nandan commented Jun 17, 2025

Looks like we’re missing @carbon/ibm-products as a dependency for the NoDataEmptyState in the React version?

https://stackblitz.com/github/devadula-nandan/tanstack-carbon/tree/feat/tabbed-headers-search/react/tabbed-header?file=package.json

Don’t forget we can remove the yarn.lock as well. 😄

added dependency
removed lock file. although it was not added in this pr, we have a separate issue to clean them all up #47

there seems to be some issue with react not rendering in stackblitz, looking into it

Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devadula-nandan
Copy link
Contributor Author

there seems to be some issue with react not rendering in stackblitz, looking into it.

@elycheea fixed it.

issue comes from c4ip peer dependency on react version, which made tabs to not render anything. removed ^ from package.json

@devadula-nandan devadula-nandan merged commit 074b3e1 into carbon-design-system:main Jun 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include search bar in Tabbed Header example React & WC Change Header to Tabbed header WC & React

4 participants