Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid misaligned loads from StaticRandomData in the size [4, 8] hashing case. #4743

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

ezbr
Copy link

@ezbr ezbr commented Dec 23, 2024

Avoid misaligned loads from StaticRandomData in the size [4, 8] hashing case. We can use aligned loads in this case for lower latency. We introduce the SampleAlignedRandomData function for this purpose.

@github-actions github-actions bot requested a review from jonmeow December 23, 2024 22:29
@chandlerc chandlerc self-requested a review December 24, 2024 11:38
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LG.

For others' context, the benchmark data here shows some minor improvements across the board but notably no regressions. And in general, the logic behind the change is very sound.

@chandlerc
Copy link
Contributor

(that said, looks like some CI failures -- let me know if you need help diagnosing or fixing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants