Fix #552: Pin docker-compose dependency version to 0.23.6 for CLI #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rhyslbw
suggested changes
Aug 9, 2021
There was a problem hiding this comment.
This repo uses a Yarn offline cache, and therefore changes to the old package to be removed, and the new added in the commit. Please squash the changes into a single commit and force push to this branch.
|
Sorry I don't quite understand. I did only one commit. What is it that I need to do exactly? |
|
You should observe the new version replace the old version |
|
Ah, I understand now. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#552: Error when creating database snapshot
It's not possible to create a database snapshot because it fails with
Cannot read property 'trim' of undefined.The issue exists because of a breaking change (imo a bug) introduced in
[email protected](PDMLab/docker-compose#178) which crashes whenpsis used with-q.Proposed Solution
Pin version of
docker-composeto0.23.6.Once this issue is resolved upstream, it can be updated to a more relaxed semver again that points to versions that include the fix.