Skip to content

Guild and Koios added #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Guild and Koios added #104

merged 2 commits into from
Aug 23, 2024

Conversation

redoracle
Copy link
Contributor

No description provided.

Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, there are two minor issues with this pull request:

(1) Koios link is the same as in the developer portal (links to the product). But, it needs to link to the team page of this collaboration https://koios.rest/community.html#teams to be in line with requirements on https://cardano.org/docs/tutorial/add-company/#requirements.

(2) The same applies to Guild Operators, which could link to https://cardano-community.github.io/guild-operators/contributors/, for example. (Not sure if there is a better team page)

@redoracle
Copy link
Contributor Author

Thank you for the contribution, there are two minor issues with this pull request:

(1) Koios link is the same as in the developer portal (links to the product). But, it needs to link to the team page of this collaboration https://koios.rest/community.html#teams to be in line with requirements on https://cardano.org/docs/tutorial/add-company/#requirements.

(2) The same applies to Guild Operators, which could link to https://cardano-community.github.io/guild-operators/contributors/, for example. (Not sure if there is a better team page)

My bad. Thanks Tommy.

@katomm katomm merged commit af2fccd into cardano-foundation:staging Aug 23, 2024
1 check passed
katomm added a commit that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants